Skip to content

Make FindPackage substitutions a Path to get operator / #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

Make FindPackage substitutions a Path to get operator / #494

wants to merge 1 commit into from

Conversation

@emersonknapp
Copy link
Contributor

@emersonknapp emersonknapp commented Oct 23, 2025 •
edited
Loading

Description

Part of robograph-project/planning#38
Depends on ros2/launch#914

Make FindPackage{X} substitutions a subclass of PathSubstitution to get the path join operator for free.

Lets you change:

PathSubstitution(FindPackageShare('my_pkg')) / 'launch' / 'my_launch.yaml'
# or
PathJoinSubstitution([FindPackageShare('my_pkg'), 'launch', 'my_launch.yaml'])

into

FindPackageShare('my_pkg') / 'launch' / 'my_launch.yaml'

Is this user-facing behavior change?

New user-facing capability, does not affect existing behavior

Did you use Generative AI?

no

Additional Information

@emersonknapp emersonknapp force-pushed the emerson/find-package-path-subs branch from 5e193f0 to f04646a Compare October 23, 2025 09:32
@emersonknapp emersonknapp moved this to In review in Robograph Planning Oct 23, 2025
@ahcorde
Copy link
Contributor

ahcorde commented Oct 24, 2025

Pulls: ros2/launch#914, #494
Gist: https://gist.githubusercontent.com/ahcorde/1d8541d31501406682d13767e15e788e/raw/cb7660853dbaea155933d8576f146a1a0d5953d6/ros2.repos
BUILD args: --packages-above-and-dependencies launch launch_ros test_launch_ros
TEST args: --packages-above launch launch_ros test_launch_ros
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17368

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde mentioned this pull request Oct 24, 2025
Open
@emersonknapp
Copy link
Contributor Author

emersonknapp commented Oct 28, 2025 •
edited
Loading

Pulls: ros2/launch#914, #494
Gist: https://gist.githubusercontent.com/emersonknapp/2c725d3e9c99a8e2cd15f567470d1ada/raw/cb7660853dbaea155933d8576f146a1a0d5953d6/ros2.repos
BUILD args: --packages-above-and-dependencies launch launch_ros test_launch_ros
TEST args: --packages-above launch launch_ros test_launch_ros
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17378

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
    • Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emersonknapp @ahcorde